Use bitcoin core's txospenderindex to find spending transactions#3279
Draft
Use bitcoin core's txospenderindex to find spending transactions#3279
Conversation
513211e to
d3d7f3c
Compare
00d357b to
7b7eb49
Compare
If bitcoin core's txospenderindex is enabled and sync, we'll automatically use it to find transactions that spent our channels.
On startup, eclair will check that both txindex and txospenderindex are enabled and synced, and will stop if they're not. Block scanning code used to find spending transactions is removed, we just use the txospenderindex now.
7b7eb49 to
cd31b14
Compare
Member
|
As discussed offline, imo we should make |
Member
Author
done in cd31b14. Eclair won't start if the index is not enabled and synced. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eclair now requires that bitcoin core's
txospenderindex(added in version 31.0) is available and synced, and will fail to start if it is not.Our Watcher will use the txospenderindex` to find spending transactions instead of scanning blocks (which was both expensive and limited as we would only scan a small number of blocks into the past).
Deployment note:
You must enable the new index on bitcoin core with
txospenderindex=1and wait until it is synchronised before you start eclair. Syncing the index from scratch will take a few hours, during which bitcoin core is usable (indexes are independent) but make be slower to respond.You can also copy the index from another node (that is running the same version), just copy the entire
.bitcoin/indexes/txospenderindexdirectory.The index requires an additional 88Gb as of block 944339.